New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove remaining text when the path include the occurences #324
Conversation
+ fix typo in the element name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit seems to remove most uses of PathMinOccurrence and PathMaxOccurrence but I don't understand what replaces that. Also if such edits to the Items
xml is occurring, then the same edits should effect the ebml_schema_example.xml file.
@@ -737,7 +735,7 @@ This document contains definitions of all EBML Elements of the EBML Header. | |||
|
|||
name: EBML | |||
|
|||
path: `1*1(\EBML)` | |||
path: `\EBML` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this change and the subsequent ones. If the PathMinOccurrence is not present then it is understood to be 0, so this edit seems to mean that the EBML Header is no longer required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PathMinOccurrence
and PathMaxOccurrence
are only use for global elements which \EBML
and the following ones are not:
PathMinOccurrence represents the minimum number of element path required between the EBMLFixedParent and the Global Element EBMLElementPath.
PathMaxOccurrence represents the maximum number of element path possible between the EBMLFixedParent and the Global Element EBMLElementPath
I have to rework the global elements path to make this clearer (#326)
Basically, most pathes don't have occurences in them anymore. Only the Global Elements do (for now).
I suggest closing in favor of #331 |
No objection although one can be done after the other (there won't be any conflict) |
closing in favor of the work completed in #331 |
Adressing a comment from Benjamin Kaduk https://mailarchive.ietf.org/arch/msg/cellar/epuOIwz8VXiu3V9-AbHNa7BRZjY