Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining text when the path include the occurences #324

Closed
wants to merge 3 commits into from

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 24, 2019

@robUx4 robUx4 added bug clarifications Improve the readability and comprehension of the specs labels Dec 24, 2019
Copy link
Contributor

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems to remove most uses of PathMinOccurrence and PathMaxOccurrence but I don't understand what replaces that. Also if such edits to the Items xml is occurring, then the same edits should effect the ebml_schema_example.xml file.

@@ -737,7 +735,7 @@ This document contains definitions of all EBML Elements of the EBML Header.

name: EBML

path: `1*1(\EBML)`
path: `\EBML`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change and the subsequent ones. If the PathMinOccurrence is not present then it is understood to be 0, so this edit seems to mean that the EBML Header is no longer required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PathMinOccurrence and PathMaxOccurrence are only use for global elements which \EBML and the following ones are not:

PathMinOccurrence represents the minimum number of element path required between the EBMLFixedParent and the Global Element EBMLElementPath.
PathMaxOccurrence represents the maximum number of element path possible between the EBMLFixedParent and the Global Element EBMLElementPath

I have to rework the global elements path to make this clearer (#326)

Basically, most pathes don't have occurences in them anymore. Only the Global Elements do (for now).

@robUx4 robUx4 mentioned this pull request Dec 30, 2019
@dericed
Copy link
Contributor

dericed commented Dec 30, 2019

I suggest closing in favor of #331

@robUx4
Copy link
Contributor Author

robUx4 commented Dec 30, 2019

No objection although one can be done after the other (there won't be any conflict)

@dericed
Copy link
Contributor

dericed commented Jan 27, 2020

closing in favor of the work completed in #331

@dericed dericed closed this Jan 27, 2020
@robUx4 robUx4 deleted the remove-path-occurence-example branch July 2, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug clarifications Improve the readability and comprehension of the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants