Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSD add default values to unknownsizeallowed/recurring #325

Merged
merged 2 commits into from Dec 29, 2019
Merged

XSD add default values to unknownsizeallowed/recurring #325

merged 2 commits into from Dec 29, 2019

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 24, 2019

They are not required but when not present it's equivalent to being false.

Adressing a comment from Benjamin Kaduk https://mailarchive.ietf.org/arch/msg/cellar/epuOIwz8VXiu3V9-AbHNa7BRZjY

@robUx4
XSD add default values to unknownsizeallowed/recurring
c1fa79c 
They are not required but when not present it's equivalent to being false.
@robUx4 robUx4 added enhancement Add more content to the document, explaning more things XML Schema EBML Schema validation labels Dec 24, 2019
dericed
dericed approved these changes Dec 29, 2019
View reviewed changes
Copy link
Contributor

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a commit to wrap these lines as otherwise they create lines in the RFC that exceed the line width allowance

@dericed dericed merged commit 5a8ce39 into master Dec 29, 2019
@dericed dericed deleted the default-xsd-attributes branch December 29, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dericed dericed dericed approved these changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
enhancement Add more content to the document, explaning more things XML Schema EBML Schema validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robUx4 @dericed @retokromer