Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the big-endian storage of the EBML ID #347

Merged
merged 2 commits into from Jun 16, 2020
Merged

Clarify the big-endian storage of the EBML ID #347

merged 2 commits into from Jun 16, 2020

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jun 14, 2020

As suggested in AUTH48 8)

@robUx4 robUx4 added the clarifications Improve the readability and comprehension of the specs label Jun 14, 2020
@robUx4 robUx4 requested review from mbunkus and dericed June 14, 2020 07:18
@dericed
Copy link
Contributor

dericed commented Jun 16, 2020

I added a commit here as the sentence, before or after the first commit, was not a complete sentence.

dericed
dericed approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, after a 2nd commit

@robUx4
Copy link
Contributor Author

robUx4 commented Jun 16, 2020

LGTM.

@dericed dericed merged commit aeafe5d into master Jun 16, 2020
@robUx4 robUx4 deleted the clarify-id-endian branch July 2, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

@dericed dericed dericed approved these changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
clarifications Improve the readability and comprehension of the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robUx4 @dericed @mbunkus @retokromer