Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark RFC2119 keywords with **<>** to mmark turns them into BCP14 code #357

Merged
merged 2 commits into from Jun 30, 2020
Merged

mark RFC2119 keywords with **<>** to mmark turns them into BCP14 code #357

merged 2 commits into from Jun 30, 2020

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jun 27, 2020

No description provided.

@robUx4 robUx4 added the formatting Fix formating issues, rearrange the content label Jun 27, 2020
@robUx4
Copy link
Contributor Author

robUx4 commented Jun 28, 2020

Rebased on top of #361 as it should be the first thing merged before we actually change the content of the files.

dericed
dericed approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a Mac, this works on a Mac if I install brew install gnu-sed coreutils and then change the Makefile to use date->gdate, head->ghead, sed->gsed. The changes in the xml from draft-ietf-cellar-ebml-18.xml to rfc8794.xml look good to me.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated
-e 's@BCP 14@BCP\&nbsp;14@' \
-e 's@<dd><t>@<dd>@' \
$< | \
awk 1 RS='</t>\n</dd>' ORS='</dd>' | head -n -1 > $@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, same issue, works with gnu head but not macOS head.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to find a way to run a macOS shell. This kind of discrepancies can be detected in bootstrap and adjust the commands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that that needs to block the PR. I can see that it works and hope to replace the head and sed with a process that works well natively on mac.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I tried with FreeBSD but still have to come up with a proper solution (otherwise a better way to remove the </t> from </t>\n</dd> than awk would be better). xsltproc is also not an option as it will mess the newlines in the text (I think)

@robUx4 robUx4 merged commit 6af3f42 into master Jun 30, 2020
@robUx4 robUx4 deleted the rfc2119-keywords branch June 30, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dericed dericed dericed approved these changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
formatting Fix formating issues, rearrange the content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robUx4 @dericed @retokromer