Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding plots get triggered during long brush strokes #39

Open
kevinyamauchi opened this issue Mar 20, 2024 · 1 comment
Open

embedding plots get triggered during long brush strokes #39

kevinyamauchi opened this issue Mar 20, 2024 · 1 comment

Comments

@kevinyamauchi
Copy link
Collaborator

kevinyamauchi commented Mar 20, 2024

I noticed that sometimes when painting with long brush strokes, the plot update gets triggered.

To reproduce, I think it's something like:

  1. paint one stroke and release the mouse button
  2. In less than one second (the debounce duration), start painting again
  3. if you don't complete the paint stroke before 1s after (1), I think the drawing gets triggered.

We can consider using the labels_update event instead. I think that gets triggered during the draw of the paint stroke.

@kevinyamauchi
Copy link
Collaborator Author

kevinyamauchi commented Mar 20, 2024

I tried switching to the labels_update event and it helps for all cases except for when the user stops moving the mouse while painting (i.e., pauses in place while holding the mouse button down). We may have to figure out a way to check both that painting has stopped before triggering the redraw and cancel the redraw if the user starts moving the mouse again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant