Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on removing an item after stopping playback #71

Closed
gnarula opened this issue Oct 26, 2015 · 0 comments
Closed

Crash on removing an item after stopping playback #71

gnarula opened this issue Oct 26, 2015 · 0 comments

Comments

@gnarula
Copy link
Contributor

gnarula commented Oct 26, 2015

Steps to reproduce this:

  • Open a file
  • Stop the playback by clicking on the stop icon
  • Remove the file from the playlist

Results in a traceback similar to

** (gnome-mpv:21451): CRITICAL **: MPV API error: error running command

gnome-mpv(+0xeea4)[0x56074d959ea4]
gnome-mpv(+0xe722)[0x56074d959722]
gnome-mpv(+0xdec8)[0x56074d958ec8]
/usr/lib/libgtk-3.so.0(+0x21326c)[0x7f159e41626c]
/usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x145)[0x7f159cb97035]
/usr/lib/libgobject-2.0.so.0(+0x22081)[0x7f159cba9081]
/usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0xa59)[0x7f159cbb18b9]
/usr/lib/libgobject-2.0.so.0(g_signal_emit+0x8f)[0x7f159cbb214f]
/usr/lib/libgtk-3.so.0(+0x35040c)[0x7f159e55340c]
/usr/lib/libgtk-3.so.0(+0x2107d9)[0x7f159e4137d9]

I guess this is because the "stop" command stops playback and clears the playlist as well. Modifying the playlist thereafter results in a crash.

A plausible solution is to mimic the stop behaviour by pausing playback and seeking to the beginning of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant