Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak Celluloid doesn't close files properly. #778

Closed
Fraetor opened this issue May 21, 2022 · 2 comments
Closed

Flatpak Celluloid doesn't close files properly. #778

Fraetor opened this issue May 21, 2022 · 2 comments

Comments

@Fraetor
Copy link

Fraetor commented May 21, 2022

Overview Description:
The Flatpak version of Celluloid doesn't properly close the file after being closed, which means that if you then delete the file it the space is not reclaimed.

image
xdg-document-portal is the process holding onto the file.

Steps to Reproduce:

  1. Play video with Flatpak Celluloid.
  2. Close Celluloid, and delete the video. It makes it easier to locate in the next step if your rm video.mp4 directly.
  3. list open, but unlinked files with lsof +L1 | grep xdg, and see if your video file is there.

Actual Results:
The file remains open even after celluloid has closed and the file has been deleted.

Expected Results:
The file is closed, and the space it occupied is released.

Version:
0.23 Flatpak

Additional Information:
This might very well be a bug in Flatpak, but I though it was worth asking here first.

@gnome-mpv
Copy link
Collaborator

Yeah. This looks more like a bug in xdg-desktop-portal.

@Fraetor
Copy link
Author

Fraetor commented Nov 30, 2023

This issue (flatpak/xdg-desktop-portal#689) is now fixed upstream with flatpak/xdg-desktop-portal#1190.

This has been released in xdg-desktop-portal 1.18.2.

@Fraetor Fraetor closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants