Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"preinstall" script shouldn't sneaky update the global git config #10919

Open
sergeys-opera opened this issue Jan 30, 2024 · 0 comments
Open

Comments

@sergeys-opera
Copy link

sergeys-opera commented Jan 30, 2024

Expected Behavior

"preinstall" script should only update the local git configuration. Or the developers should be instructed to update the global git config manually.

Current Behavior

"preinstall" script forces https instead of ssh for git globally for all the projects and not only for celo-monorepo: https://github.com/celo-org/celo-monorepo/blob/master/package.json#L8

This is what I get in my global git config after running the "preinstall" script:

$ git config --global --edit
[url "https://"]
        insteadOf = ssh://

This might lead to unexpected errors when fetching source code from other repositories that don't allow https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant