Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas SBAT variably-charged based off of exponent in fracMulExp precompile #250

Open
nityas opened this issue Jun 7, 2019 · 1 comment
Open
Labels
theme: housekeeping About making code cleaner, more maintenability, testability, etc triage Issue needs triaging

Comments

@nityas
Copy link
Contributor

nityas commented Jun 7, 2019

Expected Behavior

we current charge a flat rate(1050) that covers up to an exponent of 10^3, this should vary with the log of the exponent

this also needs to be updated in the following places:

  • fc-fractionmulexp.js in ethereumjs-vm
  • fractionMulExp in StableToken.sol

Current Behavior

fixed gas cost

@nityas nityas changed the title gas SBAT variably-charged based off of exponent in fracMulExp prcompile gas SBAT variably-charged based off of exponent in fracMulExp precompile Jun 7, 2019
@timmoreton timmoreton added this to To do in Alfajores+1 via automation Jul 23, 2019
@timmoreton timmoreton removed this from To do in Alfajores+1 Jul 24, 2019
@prestwich
Copy link
Contributor

prestwich commented Nov 3, 2020

I vote to close in favor of adopting EIP-2565.

edit: updating this off the cuff response :)

I am unclear on the use case, but it seems we can always compute something simpler than fracMulExp using modExp

@mcortesi mcortesi added the theme: housekeeping About making code cleaner, more maintenability, testability, etc label Feb 22, 2021
@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: housekeeping About making code cleaner, more maintenability, testability, etc triage Issue needs triaging
Projects
None yet
Development

No branches or pull requests

5 participants