Add CeloDance Wallet to Celo use-contractkit #33
Conversation
as a celo mobile wallet, celodance support the transfer and staking of celo assets. after talking with clabs and moola, we propose to integrate celodance wallet to moola. the development work is all finished, so please merge the code, thanks!
| @@ -72,6 +72,34 @@ | |||
| "@babel/helper-validator-identifier" "^7.14.9" | |||
| to-fast-properties "^2.0.0" | |||
|
|
|||
| "@celo-tools/use-contractkit@1.1.0": | |||
There was a problem hiding this comment.
Why has the yarn.lock file changed?
| [SupportedProviders.CeloDance]: { | ||
| name: 'CeloDance', | ||
| description: | ||
| 'Send、Vote and Earn rewards within one wallet', |
There was a problem hiding this comment.
I think you've used the wrong character here for the , after 'Send'.
Also please change the casing to 'Send, vote, and earn'
| icon: CELODANCE, | ||
| canConnect: () => true, | ||
| showInList: () => true, | ||
| listPriority: () => 0, |
| props | ||
| ) => ( | ||
| <svg width="981px" height="981px" viewBox="0 0 981 981" fill="#ffffff" style={{ height: '42px', width: '42px' }} version="1.1" xmlns="http://www.w3.org/2000/svg"> | ||
|
|
There was a problem hiding this comment.
please clean up the spacing
| @@ -481,3 +481,21 @@ export const CHROME_EXTENSION_STORE: React.FC<React.SVGProps<SVGSVGElement>> = ( | |||
| /> | |||
| </svg> | |||
| ); | |||
|
|
|||
| export const CELODANCE: React.FC<React.SVGProps<SVGSVGElement>> = ( | |||
| @@ -356,3 +356,85 @@ export class WalletConnectConnector implements Connector { | |||
| return wallet.close(); | |||
| } | |||
| } | |||
|
|
|||
| export class CeloDanceConnector implements Connector { | |||
There was a problem hiding this comment.
Why have you created a new connector? It seems to be just a copy of another connector
|
@1035569003 In addition to the changes I requested, we'll need to chat with you briefly on Discord before we accept code changes. Your Github account is brand new and has no name. It simply looks too suspicious. |
hi，it's our new developer and he use his new account. sure please contact us in discord, the handle is Emma | Bi23 Labs#9980. thank you very much! |
as a celo mobile wallet, celodance support the transfer and staking of celo assets. after talking with clabs and moola, we propose to integrate celodance wallet to moola. the development work is all finished, so please merge the code, thanks!