Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.1 #56

Closed
wants to merge 1 commit into from
Closed

1.3.1 #56

wants to merge 1 commit into from

Conversation

dckesler
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 19, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c-labs/use-contractkit/2ed6jGBewx31bgrAtTYwdcW7hNHC
✅ Preview: https://use-contractkit-git-dckesler-130-c-labs.vercel.app

jmrossy
jmrossy reviewed Oct 19, 2021
View reviewed changes
packages/use-contractkit/package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@celo-tools/use-contractkit",
"version": "1.2.0-dev",
"version": "1.3.0-dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep the -dev? That would usually be used when the commited version > published version so the yarn workspace can pick it up. Asking because I assume you're publishing soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm actually a bit unclear as to the system we're using for the -dev. When I looked at the readme explaining it in the monorepo I felt unsure about preemptively bumping the version number. I suppose I could put this to 1.3.1-dev now since 1.3.0 is out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 1.3.1-dev would be the idea now that 1.3.0 is out

@dckesler dckesler changed the title 1.3.0 1.3.1 Oct 21, 2021
@dckesler dckesler closed this Dec 14, 2021
@dckesler dckesler deleted the dckesler/1.3.0 branch May 3, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dckesler @jmrossy