Update to Swift 5 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Du Bois <alex.dubois@mac.com>
Signed-off-by: Alex Du Bois <alex.dubois@mac.com>
|
@initFabian If you want to update CI to Swift 5, I’d expect tests to continue to pass. Then we can merge this puppy, and cut a new release. |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 25 25
Lines 1429 1429
=======================================
Hits 1360 1360
Misses 69 69Continue to review full report at Codecov.
|
|
Whats the status of this PR? is it simply merging and deploying a new build? |
|
Will this address #33? |
|
Yes. This should resolve #33, and it’s ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@initFabian I upgraded the Swift version, and to make it easier to update in the future, it is only declared at the project level. All targets will inherit from the one setting.
As noted in the previous PR, this should be tagged as a new release. No code changes were needed from Swift 4.2, so I would think this can be v2.2, but upgrading to Swift 5 could be considered a breaking change, so v3.0 is also a viable option.