Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add "Block all" mode #1382

Open
plkonbklo opened this issue Apr 24, 2024 · 5 comments
Open

[Feature Request] Add "Block all" mode #1382

plkonbklo opened this issue Apr 24, 2024 · 5 comments
Assignees
Milestone

Comments

@plkonbklo
Copy link

I have two profiles with separate set of apps and separate Rethink rules.
I want to be able to block network access for all apps in one of the profiles to only allow access to the network for the apps in the second profile.
On the Rethink Home there is an arrow to the right of the START button that allow to choose the current mode:

  • DNS
  • Firewall
  • DNS + Firewall

Is it possible to add "Block all" mode here?

@ignoramous
Copy link
Collaborator

ignoramous commented Apr 24, 2024

Is it possible to add "Block all" mode here?

In Configure -> Firewall -> Universal firewall rules, enable Block all except bypassed apps and IPs. Turning this ON would block ALL apps which aren't:

  1. Either: Bypass DNS and Firewall
  2. Or: Bypass Universal
  3. Or: Isolated

As for "profiles", see:

(closing this; feel free to reopen if your request isn't covered by the 2 scenarios mentioned above).

@ignoramous ignoramous closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@plkonbklo
Copy link
Author

In Configure -> Firewall -> Universal firewall rules, enable Block all except bypassed apps and IPs. Turning this ON would block ALL apps which aren't:

1. Either: _Bypass DNS and Firewall_

2. Or: _Bypass Universal_

3. Or: _Isolate_d

I already have Block all except bypassed apps and IPs enabled in Rethink in both profiles with some apps in Isolated mode. I want to block all connections in a profile even the ones that are allowed in Isolated app or bypassed.

Just to give some more information about my case:
I have Shelter app installed that creates Work profile in addition to a Personal profile.
Both profiles are active at the same time.
I have Rethink installed in both profiles and both profiles have different apps installed and have different Rethink configs.
But I can't disable network access for specific profile in Android.
I want to enable networking in Work profile when I'm at work and disable networking in Work profile when I'm at home.

As for "profiles", see:

https://github.com/celzero/rethink-app/issues/406

I could use this feature with firewall profiles to achieve my goal of blocking all apps using separate profile.
But it's unknown as to how much time and effort it'll take to implement this firewall profiles feature.
While implementing "Block all" mode seems quite easy.
Is there some work going on on the firewall profiles feature or is it put off for somewhere in the future without any plans?

If "Block all" mode is trivial to implement then could it be implemented as a temporary solution until the time for firewall profiles feature to be implemented will come?

@ignoramous ignoramous reopened this Apr 24, 2024
@ignoramous
Copy link
Collaborator

ignoramous commented Apr 24, 2024

Gotcha. This is the reverse of "Pause" mode. Fairly trivial to implement but we are unsure how the UX should look like. Perhaps, just like the "Pause" mode (a different UI and a countdown timer)?

@plkonbklo
Copy link
Author

plkonbklo commented Apr 24, 2024

Personally I'd be okay with just changing the current mode using an arrow to the right of the START without a timer.
But I think it'd be better to implement it in the same way as Pause mode for the sake of intuitiveness for the user.
Add the "Block all"/"Offline" button near the "Pause" button with some intuitive icon like this:
https://icon-library.com/images/offline-icon/offline-icon-19.jpg
The pause mode can only be paused for specific amount of time but I'd like to have the ability to disable the networking without a timer as well, until I'll manually enable it again.
And if someone would like to disable networking for half a day it'd be a pain to change the time using +/- buttons and it'd be easier to have an ability to set the desired time using keyboard or separate +/- buttons for hours/minutes/seconds.
I don't think I'd personally use a timer for "Block all" mode but other users could need this timer feature (maybe not as a countdown timer but as a trigger at specified time) e.g. when their working time will start they need to be online in the Work profile.

@ignoramous
Copy link
Collaborator

Makes sense, thanks. We'll consider impl this at an opportune time.

@ignoramous ignoramous added this to the v056 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants