Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local blocklists are downloaded on all variants when a newer version is available #610

Closed
ignoramous opened this issue Oct 27, 2022 · 3 comments
Closed

Local blocklists are downloaded on all variants when a newer version is available #610

ignoramous opened this issue Oct 27, 2022 · 3 comments
Assignees
@hussainmohd-a
Labels
P0 Priority: 0 (urgent and important)

Comments

@ignoramous
Copy link
Collaborator

Logs whenever the Rethink DNS+ (remote) configure page is loaded into the fragment.

10-27 18:43:05.143   758   893 D DispPerfService: onframeavailable pid=12771, slot=2, seq=16151, name=com.celzero.bravedns:com.celzero.bravedns/com.celzero.bravedns.ui.ConfigureRethinkBasicActivity#1
10-27 18:43:10.672 12771 12866 I WM-WorkerWrapper: Worker result SUCCESS for Work [ id=6834351b-8fd2-4ac8-9e9e-422cb9341734, tags={ com.celzero.bravedns.customdownloader.LocalBlocklistDownloader, CUSTOM_DOWNLOAD_WORKER } ]
10-27 18:43:10.677 12771 12771 I VpnLifecycle: onPrefChange key: local_block_list_downloaded_time, opts: TunnelOptions(tunDnsMode=DOH_PORT, tunFirewallMode=FILTER_ANDROID9_ABOVE, tunProxyMode=NONE, ptMode=PTMODEAUTO, blocker=com.celzero.bravedns.service.BraveVPNService@a253b05, listener=com.celzero.bravedns.service.BraveVPNService@a253b05, fakeDns=10.111.222.3:53, preferredEngine=IPv4)
10-27 18:43:10.834 12771 12922 I DnsManager: New Local blocklist files inserted into database
10-27 18:43:17.337  1540  4090 I ActivityTaskManager: START u0 {cmp=com.celzero.bravedns/.ui.ConfigureRethinkBasicActivity (has extras) mCallingUid=10284} from uid 10284 and from pid 12771
10-27 18:43:17.590 12771 12771 I VpnLifecycle: onPrefChange key: local_block_list_downloaded_time, opts: TunnelOptions(tunDnsMode=DOH_PORT, tunFirewallMode=FILTER_ANDROID9_ABOVE, tunProxyMode=NONE, ptMode=PTMODEAUTO, blocker=com.celzero.bravedns.service.BraveVPNService@a253b05, listener=com.celzero.bravedns.service.BraveVPNService@a253b05, fakeDns=10.111.222.3:53, preferredEngine=IPv4)
10-27 18:43:17.590 12771 12771 I DownloadManager: Check for download, download type REMOTE url: https://download.rethinkdns.com/update/blocklists?tstamp=1627901743446&vcode=22
10-27 18:43:17.598 12771 12771 D DnsManager: Check for blocklist update, status: -1
10-27 18:43:17.767 12771 12771 D DnsManager: Check for blocklist update, status: 1664427564128
10-27 18:43:17.769 12771 12771 I VpnLifecycle: onPrefChange key: custom_downloader_last_generated_id, opts: TunnelOptions(tunDnsMode=DOH_PORT, tunFirewallMode=FILTER_ANDROID9_ABOVE, tunProxyMode=NONE, ptMode=PTMODEAUTO, blocker=com.celzero.bravedns.service.BraveVPNService@a253b05, listener=com.celzero.bravedns.service.BraveVPNService@a253b05, fakeDns=10.111.222.3:53, preferredEngine=IPv4)
10-27 18:43:17.774 12771 12771 I VpnLifecycle: onPrefChange key: custom_downloader_last_generated_id, opts: TunnelOptions(tunDnsMode=DOH_PORT, tunFirewallMode=FILTER_ANDROID9_ABOVE, tunProxyMode=NONE, ptMode=PTMODEAUTO, blocker=com.celzero.bravedns.service.BraveVPNService@a253b05, listener=com.celzero.bravedns.service.BraveVPNService@a253b05, fakeDns=10.111.222.3:53, preferredEngine=IPv4)

...

10-27 18:43:17.818 12771 12916 D BaseJobBuilder: set process for client: com.celzero.bravedns
10-27 18:43:17.870 12771 12919 I WM-WorkerWrapper: Worker result RETRY for Work [ id=d4b8eb67-eb61-47d9-8a55-ad7d2de76510, tags={ com.celzero.bravedns.customdownloader.LocalBlocklistDownloader, CUSTOM_DOWNLOAD_WORKER } ]
10-27 18:43:17.986 12771 12919 D BaseJobBuilder: set process for client: com.celzero.bravedns
10-27 18:43:18.342 12771 19266 I DownloadManager: Download success for file /data/data/com.celzero.bravedns/files/local_blocklist/1664427564128/filetag.json
10-27 18:43:18.415 12771 19266 I DownloadManager: Download success for file /data/data/com.celzero.bravedns/files/local_blocklist/1664427564128/basicconfig.json
...
10-27 18:43:21.609 12771 16026 I DownloadManager: Download success for file /data/data/com.celzero.bravedns/files/local_blocklist/1664427564128/rd.txt
...
10-27 18:43:27.899 12771 12920 I WM-WorkerWrapper: Worker result RETRY for Work [ id=d4b8eb67-eb61-47d9-8a55-ad7d2de76510, tags={ com.celzero.bravedns.customdownloader.LocalBlocklistDownloader, CUSTOM_DOWNLOAD_WORKER } ]
10-27 18:43:28.027 12771 12920 D BaseJobBuilder: set process for client: com.celzero.bravedns
...
@ignoramous ignoramous added the P0 Priority: 0 (urgent and important) label Oct 27, 2022
@ignoramous
Copy link
Collaborator Author

This could be the cause of high bandwidth consumption folks are complaining about: #530

@ignoramous
Copy link
Collaborator Author

rethink-app/app/src/main/java/com/celzero/bravedns/ui/RethinkBlocklistFragment.kt

Line 201 in 5c85c9c

downloadLocalBlocklist(it)

must be like what's in

rethink-app/app/src/main/java/com/celzero/bravedns/ui/RethinkListFragment.kt

Line 440 in 5c85c9c

download(it)

@ignoramous ignoramous changed the title Local blocklists are downloaded on all variants when update Local blocklists are downloaded on all variants when a newer version is available Oct 27, 2022
@hussainmohd-a
Copy link
Collaborator

Fixed: 06f51c4, 506fa2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hussainmohd-a hussainmohd-a

Labels
P0 Priority: 0 (urgent and important)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ignoramous @hussainmohd-a