Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-running visualization if process has failed #11

Open
MarkUoLeeds opened this issue Feb 22, 2019 · 2 comments
Open

Re-running visualization if process has failed #11

MarkUoLeeds opened this issue Feb 22, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@MarkUoLeeds
Copy link
Member

Expected Behavior

If the forecast process has failed and a repeat run is requested then the visualization step should not interfere with the existing symbolic links.

Scenario1: if the failed forecast is not discovered until next day ( or even a Monday after a weekend) then the repeat of the forecast can be run using the "-d YYYYMMDD" option. However if the forecast worked on the day when this repeat is run then the "Today" symlink in the visualization directory should not change.

Scenario2: if the forecast has also failed each day since the first failure then the final symbolic link should point to the chosen day ("Today" matches the date of the simulation requested).

Scenario3: normal operation the "Today" symlink will be directed to the $rundate which is the same as the date that the forecast is being run.

Current Behavior

the Run.sh currently sets the symlink to match the requested $rundate only

Possible Solution

Steps to Reproduce (for bugs)

Context

Improve the robustness of the forecasting system to cope with unforeseen failures in supporting systems.

Your Environment

  • Browser Name and version: N/A
  • Operating System and version (desktop or mobile):
    foe-linux-04 at UoLeeds

Any other relevant information

@cemachelen cemachelen self-assigned this Feb 22, 2019
@cemachelen cemachelen added the bug Something isn't working label Feb 22, 2019
@cemachelen cemachelen added this to To do in UNRESP_FORECAST_VIZ via automation Feb 22, 2019
@cemachelen
Copy link
Member

In progress

This issue has been partially fixed Today now links to Today's date.

Version 2.1 Now includes a suite of command line options including a viz only option

./Run.sh
 optional arguments:
  -d <date> YYYYMMDD DEFAULT: <todays date>
  -n <home> name of viz defaults to ~earunres
 The following switches can be used to overwrite
 Default behaviour.
  -m turn OFF FORECAST Model (e.g. to run viz option only)
  -p turn OFF viz steps (no jpgs etc to be produced)
  -f turn ON ffmpeg mp4 production

For help run .\Run.sh -h

@cemachelen
Copy link
Member

TO DO

The current fix replaces ln -sf $rundate Today with ln -sf $(date +%Y%m%d) Today

  1. Wrap an if clause: if rundate != today then leave the link alone, unless an override flag is set
  2. Add in an override option

@cemachelen cemachelen moved this from To do to In progress in UNRESP_FORECAST_VIZ Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
UNRESP_FORECAST_VIZ
  
In progress
Development

No branches or pull requests

2 participants