Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Regression Tests and Examples #126

Closed
4 tasks done
jpmorgan98 opened this issue Sep 29, 2023 · 6 comments
Closed
4 tasks done

Updating Regression Tests and Examples #126

jpmorgan98 opened this issue Sep 29, 2023 · 6 comments
Assignees

Comments

@jpmorgan98
Copy link
Collaborator

jpmorgan98 commented Sep 29, 2023

The MPI issues keep failing out after repos are forked and we need to do better about testing all functionality. The specific tests we need to add:

  • Parallel regression test
  • Numba regression test
  • MPI & Numba Regression tests
  • Updating examples to have current functionality
    I think as a stop gap measure we can write a number of SLURM or LSF batch scripts for Lassen or Quartz to at least somewhat optimize the process tho let me know what yall think.
@ilhamv
Copy link
Collaborator

ilhamv commented Nov 25, 2023

Effort to address this: #131

@jpmorgan98
Copy link
Collaborator Author

I think we should retool the tests to not be so long. I will tackle this!

@ilhamv
Copy link
Collaborator

ilhamv commented Jan 5, 2024

Also, note that now we do mpi test with mpiexec=2 and mpiexec=4. We can just do one of them.

@jpmorgan98
Copy link
Collaborator Author

Ya I think a github action only gives us 2 CPU cores anyways.

@spasmann
Copy link
Collaborator

spasmann commented Jan 5, 2024

Dang. 4 would be ideal for DD tests.

@jpmorgan98
Copy link
Collaborator Author

We can still launch 4 threads in that case they just wont be at all performant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants