Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE trying to us the node/repl-env in new clojurescript #35

Closed
rhg opened this issue Jan 3, 2015 · 6 comments
Closed

NPE trying to us the node/repl-env in new clojurescript #35

rhg opened this issue Jan 3, 2015 · 6 comments
Milestone

Comments

@rhg
Copy link

rhg commented Jan 3, 2015

The newer builds of cljs have a node repl which works fine without piggieback/nrepl as per http://swannodette.github.io/2014/12/31/the-old-way-the-new-way/ except im using the latest release not from git (0.0-2655). I'm also using clojure 1.7.0-alpha4 and piggieback 0.1.3.

@cemerick
Copy link
Collaborator

cemerick commented Jan 4, 2015

Yes, piggieback likely requires updating to work with the latest changes to how ClojureScript REPLs work. I have not yet looked at what's necessary in detail. Happy to take a PR if someone would like to contribute.

@cemerick cemerick added this to the NEXT milestone Jan 4, 2015
@rhg
Copy link
Author

rhg commented Jan 4, 2015

I'll dig in later today and send a PR.
On Jan 3, 2015 10:16 PM, "Chas Emerick" notifications@github.com wrote:

Yes, piggieback likely requires updating to work with the latest changes
to how ClojureScript REPLs work. I have not yet looked at what's necessary
in detail. Happy to take a PR if someone would like to contribute.


Reply to this email directly or view it on GitHub
#35 (comment).

@nbeloglazov
Copy link

Have similar problem with latest clojurescript 0.0-2665 and cljx which uses piggieback. Can't start regular clojure repl. Example project.clj:

(defproject bug "0.1.0-SNAPSHOT"
  :dependencies [[org.clojure/clojure "1.6.0"]
                 [org.clojure/clojurescript "0.0-2665"]]
  :plugins [[com.keminglabs/cljx "0.5.0"]])

And the error of running lein repl:

Error loading cljx.repl-middleware: java.lang.IllegalArgumentException: No single method: _setup of interface: cljs.repl.IJavaScriptEnv found for function: -setup of protocol: IJavaScriptEnv, compiling:(cemerick/piggieback.clj:149:5)
Exception in thread "main" java.lang.RuntimeException: Unable to resolve var: cljx.repl-middleware/wrap-cljx in this context, compiling:(/tmp/form-init6807809113808791412.clj:1:5337)
    at clojure.lang.Compiler.analyzeSeq(Compiler.java:6651)
    at clojure.lang.Compiler.analyze(Compiler.java:6445)
    at clojure.lang.Compiler.analyze(Compiler.java:6406)

@viesti
Copy link

viesti commented Jan 5, 2015

David Nolen has been quite active :) The above exception stems from API changes: https://github.com/clojure/clojurescript/wiki/Custom-REPLs#expectations

@nbeloglazov
Copy link

Cljx issue it not actually related to this one because cljx started to happen only in clojurescript 0265 version while this one started in 2655. I've created a separate issue: #36. Sorry for confusion.

@cemerick
Copy link
Collaborator

cemerick commented Jan 9, 2015

Fixed on master, will be released in 0.1.4 shortly.

@cemerick cemerick closed this as completed Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants