Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brakes down in clojure 1.9.0-alpha12 #75

Closed
gavlooth opened this issue Aug 13, 2017 · 4 comments
Closed

Brakes down in clojure 1.9.0-alpha12 #75

gavlooth opened this issue Aug 13, 2017 · 4 comments

Comments

@gavlooth
Copy link

It seems to brake when used in clojure 1.90-aopha 12. I get the following error in stack trace

Error loading cemerick.piggieback: clojure.lang.ExceptionInfo: Call to clojure.core/ns did not conform to spec:
In: [1] val: ((require [clojure.string :as string] [cljs.source-map.base64 :as base64])) fails at: [:args] predicate: (cat :docstring (? string?) :attr-map (? map?) :clauses :clojure.core.specs/ns-clauses), Extra input
:clojure.spec/args (cljs.source-map.base64-vlq (require [clojure.string :as string] [cljs.source-map.base64 :as base64]))
#:clojure.spec{:problems [{:path [:args], :reason "Extra input", :pred (cat :docstring (? string?) :attr-map (? map?) :clauses :clojure.core.specs/ns-clauses), :val ((require [clojure.string :as string] [cljs.source-map.base64 :as base64])), :via [], :in [1]}], :args (cljs.source-map.base64-vlq (require [clojure.string :as string] [cljs.source-map.base64 :as base64]))}, compiling:(cljs/source_map/base64_vlq.clj:1:1)
WARNING: pprint already refers to: #'clojure.core/pprint in namespace: puget.printer, being replaced by: #'puget.printer/pprint
.
.
.
Exception in thread "main" java.lang.RuntimeException: Unable to resolve var: cemerick.piggieback/wrap-cljs-repl in this context, compiling:(C:\Users\gavlo\AppData\Local\Temp\form-init1568080918341780644.clj:1:8253).

@cemerick
Copy link
Collaborator

This appears to be the result of tighter constraints on ns forms in the newer Clojure / ClojureScript, which piggieback doesn't / can't control. Does this code load/compile without piggieback involved?

@gavlooth
Copy link
Author

Yes, without piggieback compiles ok
.

@vspinu
Copy link

vspinu commented Aug 14, 2017

Error comes from cljs stack somewere. require is now enforced to be a keyword :require. Upgrading to clojurescript 1.9.854 fixed the issue for me.

@bbatsov
Copy link
Contributor

bbatsov commented Mar 14, 2018

@bhauman just bumped the cljs dep on master, so I guess this should fix the problem.

@bbatsov bbatsov closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants