Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add DPI aware for Windows build. #828

Closed
SlimeNull opened this issue May 22, 2023 · 4 comments · Fixed by #981
Closed

Please add DPI aware for Windows build. #828

SlimeNull opened this issue May 22, 2023 · 4 comments · Fixed by #981

Comments

@SlimeNull
Copy link

Just add the following content to application's manifest:

  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
      <longPathAware xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">true</longPathAware>
    </windowsSettings>
  </application>
@Squall-Leonhart
Copy link
Contributor

Squall-Leonhart commented May 22, 2023

That's not enough to make Cemu fully dpi aware, there are some dialogs and controls that do not scale correctly.

And this manifest doesn't even comply to modern DPI awareness capabilities.

@ghost
Copy link

ghost commented May 23, 2023

Regardless of op's opinions, this would be a good idea.

@Squall-Leonhart
Copy link
Contributor

Duplicate of #155

@dxgldotorg
Copy link

Adding longPathAware is dangerous - the developer must make sure they don't have any MAX_PATH length buffers that could be vulnerable to buffer overruns.

The manifest entry is there for the developer to attest that the application can handle paths greater than MAX_PATH lengths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants