fix(uuid): added implicit tests for 13.6, rollback to uuid working ve…

…rsion fix #28
listr2 · May 20, 2020 · 75ade63 · 75ade63
1 parent 5a3de20
commit 75ade63
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -1,7 +1,7 @@
 name: node-actions
 on:
   push:
-    branches:    
+    branches:
       - '*'
       - '*/*'
       - '!master'
@@ -25,7 +25,7 @@ jobs:
     runs-on: [ubuntu-latest]
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x]
+        node-version: [10.x, 11.x, 12.x, 13.6, 13.x, 14.x]
     steps:
     - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
@@ -39,7 +39,7 @@ jobs:
     runs-on: [ubuntu-latest]
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x]
+        node-version: [10.x, 11.x, 12.x, 13.6, 13.x, 14.x]
     steps:
     - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}

diff --git a/package.json b/package.json
@@ -54,6 +54,7 @@
   ],
   "dependencies": {
     "@samverschueren/stream-to-observable": "^0.3.0",
+    "@types/uuid": "^8.0.0",
     "chalk": "^4.0.0",
     "cli-cursor": "^3.1.0",
     "cli-truncate": "^2.1.0",
@@ -62,11 +63,11 @@
     "figures": "^3.2.0",
     "indent-string": "^4.0.0",
     "log-update": "^4.0.0",
-    "nanoid": "^3.1.9",
     "p-map": "^4.0.0",
     "pad": "^3.2.0",
     "rxjs": "^6.5.5",
-    "through": "^2.3.8"
+    "through": "^2.3.8",
+    "uuid": "^7.0.2"
   },
   "devDependencies": {
     "@cenk1cenk2/eslint-config": "*",

diff --git a/src/lib/task.ts b/src/lib/task.ts
@@ -1,7 +1,7 @@
 import sttoob from '@samverschueren/stream-to-observable'
-import { nanoid } from 'nanoid'
 import { Observable, Subject } from 'rxjs'
 import { Stream } from 'stream'
+import { v4 as uuid } from 'uuid'
 
 import { stateConstants } from '@constants/state.constants'
 import {
@@ -35,7 +35,7 @@ export class Task<Ctx, Renderer extends ListrRendererFactory> extends Subject<Li
     super()
 
     // move to private parameters
-    this.id = nanoid()
+    this.id = uuid()
     this.title = this.tasks?.title
     this.task = this.tasks.task
     // parse functions

diff --git a/yarn.lock b/yarn.lock
@@ -666,6 +666,11 @@
   resolved "https://registry.yarnpkg.com/@types/stack-utils/-/stack-utils-1.0.1.tgz#0a851d3bd96498fa25c33ab7278ed3bd65f06c3e"
   integrity sha512-l42BggppR6zLmpfU6fq9HEa2oGPEI8yrSPL3GITjfRInppYFahObbIQOQK3UGxEnyQpltZLaPe75046NOZQikw==
 
+"@types/uuid@^8.0.0":
+  version "8.0.0"
+  resolved "https://registry.yarnpkg.com/@types/uuid/-/uuid-8.0.0.tgz#165aae4819ad2174a17476dbe66feebd549556c0"
+  integrity sha512-xSQfNcvOiE5f9dyd4Kzxbof1aTrLobL278pGLKOZI6esGfZ7ts9Ka16CzIN6Y8hFHE1C7jIBZokULhK1bOgjRw==
+
 "@types/yargs-parser@*":
   version "15.0.0"
   resolved "https://registry.yarnpkg.com/@types/yargs-parser/-/yargs-parser-15.0.0.tgz#cb3f9f741869e20cce330ffbeb9271590483882d"
@@ -3679,11 +3684,6 @@ mute-stream@0.0.8:
   resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.8.tgz#1630c42b2251ff81e2a283de96a5497ea92e5e0d"
   integrity sha512-nnbWWOkoWyUsTjKrhgD0dcz22mdkSnpYqbEjIm2nhwhuxlSkpywJmBo8h0ZqJdkp73mb90SssHkN4rsRaBAfAA==
 
-nanoid@^3.1.9:
-  version "3.1.9"
-  resolved "https://registry.yarnpkg.com/nanoid/-/nanoid-3.1.9.tgz#1f148669c70bb2072dc5af0666e46edb6cd31fb2"
-  integrity sha512-fFiXlFo4Wkuei3i6w9SQI6yuzGRTGi8Z2zZKZpUxv/bQlBi4jtbVPBSNFZHQA9PNjofWqtIa8p+pnsc0kgZrhQ==
-
 nanomatch@^1.2.9:
   version "1.2.13"
   resolved "https://registry.yarnpkg.com/nanomatch/-/nanomatch-1.2.13.tgz#b87a8aa4fc0de8fe6be88895b38983ff265bd119"