Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No valid exports main found for 'listr2/node_modules/nanoid' #28

Closed
iiroj opened this issue May 20, 2020 · 5 comments
Closed

No valid exports main found for 'listr2/node_modules/nanoid' #28

iiroj opened this issue May 20, 2020 · 5 comments
Labels

Comments

@iiroj
Copy link

iiroj commented May 20, 2020

It was reported in lint-staged/lint-staged#870 that using Node.js version 13.6.0 listr2 fails to a nanoid import. The issue affects lint-staged because of the semver range allowing listr@2.0.3 to be installed. I assume this error is similar to #25

@iiroj
Copy link
Author

iiroj commented May 20, 2020

I wonder if ai/nanoid#205 is related.

@iiroj
Copy link
Author

iiroj commented May 20, 2020

I think what would be good for listr2 is to go through its dependencies engines declarations, and match the Node.js requirement.

For example, nanoid currently declares Node.js versions ^10 || ^12 || >=13.7, which would imply the same requirements for listr2 as well.

@cenk1cenk2
Copy link
Collaborator

This problen with random id generation is interesting. I do not want to limit node version with a trivial dependency as this maybe it should be best to go back to working version of ^7 of uuid

@cenk1cenk2
Copy link
Collaborator

And will add 13.6 to tests implicitly to catch this error. Might be the best workaround.

cenk1cenk2 pushed a commit that referenced this issue May 20, 2020
## [2.0.4](v2.0.3...v2.0.4) (2020-05-20)

### Bug Fixes

* **types:** match version of uuid ([33a1e80](33a1e80))
* **uuid:** added implicit tests for 13.6, rollback to uuid working version ([75ade63](75ade63)), closes [#28](#28)
@cenk1cenk2
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants