New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Disable Error Collection #615
Conversation
Thank you @BeeeQueue for this merge request, I would only change to enable this by default and merge it with your other request as a breaking change. I doubt that many people including me use this feature since it was rather fixed recently and causing more problems than it solves. Maybe we can just collect the I will merge this is hopefully tomorrow. |
Maybe a better solution would be to have the setting be something like Then it can do the full copy on |
Yeah that would be even better. What should the default will be I guess minimal without copying the context for each error it would be very hard to have a memory leak. |
Looking at the function again it would be better to just save the error and save the extra info (ctx, task) if it's not Then the question becomes how do we know which step actually errored? With no task or context in the error it becomes quite hard to tell in a big list of tasks. I added something called |
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I ran into the same(?) issue as #600 and found that commenting out https://github.com/cenk1cenk2/listr2/blob/master/src/lib/task-wrapper.ts#L58 fixed it based on the comments in the issue.
Closes #600(?)