Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-type mismatch of POST data #21

Closed
woodb opened this issue Aug 27, 2015 · 3 comments
Closed

Content-type mismatch of POST data #21

woodb opened this issue Aug 27, 2015 · 3 comments

Comments

@woodb
Copy link
Contributor

woodb commented Aug 27, 2015

It looks like the Content-Type of POST data is currently set to application/x-www-form-urlencoded, even though the data are encoded as JSON.

I might be missing a nuance of the GitHub API, but should we consider changing this to application/json instead to match?
@woodb
Copy link
Contributor Author

woodb commented Aug 27, 2015

By the way, I will gladly file a PR to fix this and #22, but I don't want dig in until PR #19 gets merged @cenkalti, what do you think?

@woodb woodb mentioned this issue Aug 27, 2015
Merged
@woodb
Copy link
Contributor Author

woodb commented Aug 27, 2015

So I ended up just adding this to PR #19, along with #22, since I had time 😸

@cenkalti
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cenkalti @woodb