Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update example to reflect the change from ExportView to ExportMetrics. #14

Closed
songy23 opened this issue Nov 1, 2019 · 0 comments · Fixed by #16
Closed

Update example to reflect the change from ExportView to ExportMetrics. #14

songy23 opened this issue Nov 1, 2019 · 0 comments · Fixed by #16
Assignees
Labels
bug Something isn't working

Comments

@songy23
Copy link
Contributor

songy23 commented Nov 1, 2019

Prometheus exporter has been updated to use metric.reader to read and export Metric instead of view.Data. The old interface ExportView is already a no-op:

// Deprecated in lieu of metricexport.Reader interface.
func (e *Exporter) ExportView(vd *view.Data) {
}

However in the example we still call the deprecated (and no-op) interface view.RegisterExporter and view.SetReportingPeriod

view.RegisterExporter(exporter)

view.SetReportingPeriod(1 * time.Second)

Example needs to be updated to reflect the change in metrics export.

/cc @yanweiguo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants