Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

The package depends on 'github.com/aws/aws-sdk-go' #60

Closed
andreisobchuck opened this issue Nov 21, 2018 · 2 comments
Closed

The package depends on 'github.com/aws/aws-sdk-go' #60

andreisobchuck opened this issue Nov 21, 2018 · 2 comments

Comments

@andreisobchuck
Copy link

andreisobchuck commented Nov 21, 2018 •
edited
Loading

Is it ok that the package depends on 'github.com/aws/aws-sdk-go'?
The total time to get all depencies in Google Cloud Builder is big.
@andreisobchuck andreisobchuck changed the title The package depends on ' The package depends on 'github.com/aws/aws-sdk-go' Nov 21, 2018
@odeke-em
Copy link
Contributor

Thank you filing this issue @andreisobchuck and welcome to the OpenCensus project!

This project needs to keep monitored resources and particularly for AWS as per https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/blob/899e456273f5c46d23aef8f0c66e899d7d1e17f4/monitoredresource/aws_identity_doc_utils.go hence we cannot remove that dependency.

/cc @rakyll @bogdandrutu

@ahmetb ahmetb mentioned this issue Jan 8, 2019
Open
@songy23
Copy link
Contributor

songy23 commented May 31, 2019

Duplicated of #144.

@songy23 songy23 closed this as completed May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@odeke-em @songy23 @andreisobchuck