Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Code clean up #10

Closed
11 tasks done
lmolkova opened this issue Jul 25, 2018 · 3 comments
Closed
11 tasks done

Code clean up #10

lmolkova opened this issue Jul 25, 2018 · 3 comments
Labels
enhancement good first issue up-for-grabs

Comments

@lmolkova
Copy link

lmolkova commented Jul 25, 2018 •
edited by SergeyKanzhelev
Loading

  • Namespaces should not contain vendor name and should be aligned with Java OC
  • unused usings
  • commented code
  • remove AsyncLocal OnChange subscription
  • code style checks
  • latest C# features: expression-bodied props, etc...
  • empty lines
  • sln project
  • gitignore
  • readme
  • making the enums pascal cased
@lmolkova lmolkova changed the title Namespaces should not contain vendor name and should be aligned with Java OC Code clean up Jul 25, 2018
@Falco20019
Copy link

I assume „code style checks“ includes making the enums pascal cased?

@lmolkova
Copy link
Author

@Falco20019
good point

@SergeyKanzhelev
Copy link
Member

I believe this is done. Codebase is still having over 550 warnings from the undocumented public APIs. But those will be tracked separately

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Falco20019 @lmolkova @SergeyKanzhelev