Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Introduce IsRemoteTrusted option to trace.StartOptions #670

Open
rakyll opened this issue Apr 4, 2018 · 1 comment
Open

Introduce IsRemoteTrusted option to trace.StartOptions #670

rakyll opened this issue Apr 4, 2018 · 1 comment

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 4, 2018

We currently provide an option for the gRPC and HTTP entry points but it is common case for users to
not to trust the incoming trace ID. Rather than providing this option at integration points, provide it on the trace.StartOptions.

    // IsPublicEndpoint should be set to true for publicly accessible HTTP(S)
    // servers. If true, any trace metadata set on the incoming request will
    // be added as a linked trace instead of being added as a parent of the
    // current trace.
    IsPublicEndpoint bool
@semistrict
Copy link
Contributor

We can do this without breaking the API by just deprecating the old way instead of removing it immediately. Removing the api-breaking tag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants