Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

exporter/zipkin: if localEndpoint is not specified, resolve it from system #390

Open
odeke-em opened this issue Feb 14, 2019 · 0 comments
Open
Assignees

Comments

@odeke-em
Copy link
Member

Currently when creating the Zipkin exporter, if no local_endpoint is specified in the configuration file, we use a phoney local endpoint URL

localEndpointURI := "192.168.1.5:5454"
if zc.LocalEndpointURI != "" {
localEndpointURI = zc.LocalEndpointURI
}

and the origins of it are I believe from copy and paste through Zipkin documents.

Because deploying many agents will require us to provide accurate information about origins of content, it is essential that we use the locally resolved address of the source as local_endpoint if none is provided.

@odeke-em odeke-em self-assigned this Feb 14, 2019
@odeke-em odeke-em added this to the 0.2.0 milestone Feb 14, 2019
@flands flands modified the milestones: 0.1.3, 0.1.4 Feb 27, 2019
@flands flands modified the milestones: 0.1.4, 0.2.0 Mar 14, 2019
@flands flands modified the milestones: 0.1.5, 0.1.6 Mar 28, 2019
@flands flands removed this from the 0.1.6 milestone Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants