Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to trailing comma style in spec/mocha.js #26

Closed
dpilafian opened this issue Oct 5, 2020 · 3 comments
Closed

Switch to trailing comma style in spec/mocha.js #26

dpilafian opened this issue Oct 5, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dpilafian
Copy link
Member

For multiline arrays and objects, the consistency of including a comma for the last item makes the code easier to edit and helps reduce merge diffs.

See:
https://jshint.com/docs/options/#trailingcomma

For example, change:

const input = {
   '$':  'Money',
   '🚀': 'Unicode'  //no comma
   };

to:

const input = {
   '$':  'Money',
   '🚀': 'Unicode',  //with comma
   };
@dpilafian dpilafian added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2020
@dpilafian
Copy link
Member Author

I should have been more clear in the original description. The trailing commas are to be applied to the coding style of the spec/mocha.js file itself.

For example, the input object on line 51 needs a trailing comma:
https://github.com/center-key/pretty-print-json/blob/master/spec/mocha.js#L51

Changing the output to include trailing commas would, unfortunately, break JSON.

"JSON, however, disallows trailing commas."

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas

@AlcidesA
Copy link
Contributor

AlcidesA commented Oct 5, 2020

Oh right, I'm gonna fix that

@dpilafian
Copy link
Member Author

PR #27 looks good.

By the way, the new fancy JSON5 supports trailing commas. The future is getting brighter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants