Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors when imported datafile has null or duplicate id values #3155

Merged
merged 5 commits into from Aug 28, 2023

Conversation

IamEzio
Copy link
Contributor

@IamEzio IamEzio commented Aug 20, 2023

Fixes #3009

Related to #3026

There was an existing code to handle errors when imported CSV or TSV files had null or duplicate id values. It was not working due to a small mistake. This PR fixes that mistake and replicates that logic for JSON and Excel files.
The logic of the existing code:

When the data imported from the datafile has null or duplicate id values, we rename the column to `id_original` and add another `id` column with default id values.

Screenshots

The video below shows the implementation of the above stated logic for csv, json and excel files.

null_and_duplicate_id.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@IamEzio IamEzio added the work: backend Related to Python, Django, and simple SQL label Aug 20, 2023
@IamEzio IamEzio added this to the GSoC 2023 milestone Aug 20, 2023
@IamEzio IamEzio requested a review from dmos62 August 20, 2023 12:22
@IamEzio IamEzio marked this pull request as draft August 20, 2023 12:22
@IamEzio IamEzio marked this pull request as ready for review August 22, 2023 05:06
@IamEzio
Copy link
Contributor Author

IamEzio commented Aug 28, 2023

@dmos62 I have added the required tests. PTAL. Thanks!

@dmos62 dmos62 added this pull request to the merge queue Aug 28, 2023
Merged via the queue into mathesar-foundation:develop with commit dd72383 Aug 28, 2023
9 checks passed
@IamEzio IamEzio deleted the null-id-fix branch August 29, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Error when imported data file has null or duplicate id value
2 participants