Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mean aggregation function #2916

Conversation

Aritra8438
Copy link
Member

@Aritra8438 Aritra8438 commented Jun 5, 2023

Fixes #2915

This pull request adds support for Mean aggregation as a transformation step in the data explorer.

User will be able to:

  • Get Mean of integer columns based on Group By clause.
  • Get Mean of decimal columns based on Group By clause.

Technical details

I have made the following changes:

  • Add Mean(DBFunction) class to support mean aggregation
  • Add mean suffix to the output alias of the aggregated column.
  • Add Mean to the list of transformation steps in the data explorer.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rajatvijay rajatvijay added this to the GSoC 2023 milestone Jun 5, 2023
@mathemancer mathemancer self-requested a review June 9, 2023 08:55
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back end changes look good. To merge, you need to:

  • sort out merge conflicts.
  • get the front end bit added.

@Aritra8438 Aritra8438 marked this pull request as ready for review June 14, 2023 10:38
@Aritra8438 Aritra8438 added the pr-status: review A PR awaiting review label Jun 14, 2023
@Aritra8438 Aritra8438 self-assigned this Jun 14, 2023
@Aritra8438
Copy link
Member Author

Hi @mathemancer and @seancolsen. This PR is stacked on #2914, which is again stacked on #2912.

So, the ideal order of merging will be, #2912 -> #2914 -> #2916.

@Aritra8438 Aritra8438 mentioned this pull request Jun 14, 2023
7 tasks
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work as usual!

@mathemancer mathemancer added this pull request to the merge queue Jun 16, 2023
@mathemancer mathemancer merged commit ad605b5 into mathesar-foundation:develop Jun 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Support for mean aggregation function while summarizing columns
4 participants