Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to check importing json feature #2933

Merged
merged 3 commits into from Jun 22, 2023

Conversation

IamEzio
Copy link
Contributor

@IamEzio IamEzio commented Jun 9, 2023

Related to #2895

This PR adds tests to check if a happy JSON (a valid consistent JSON) file is imported correctly.

Screenshots

NA

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@IamEzio
Copy link
Contributor Author

IamEzio commented Jun 9, 2023

@dmos62 PTAL. Thanks!

@IamEzio IamEzio added the pr-status: review A PR awaiting review label Jun 9, 2023
@IamEzio IamEzio added this to the GSoC 2023 milestone Jun 9, 2023
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Note, the tests in mathesar/tests/imports/test_json.py are not API tests, thus how well they test full vertical intergration is not clear. I suspect you chose to use limited-verticality tests (for the lack of a better term) here, because that's what was done for CSVs. That's fine, but keep in mind that you probably don't want to keep investing in non-API tests: think of non-API tests as development aids, and think of API tests as correctness guarantees.

@dmos62 dmos62 added this pull request to the merge queue Jun 22, 2023
Merged via the queue into mathesar-foundation:develop with commit c5a7790 Jun 22, 2023
7 checks passed
@IamEzio IamEzio deleted the json-tests branch June 25, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants