Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peak Month aggregation function. #3006

Merged
merged 36 commits into from Jul 24, 2023
Merged

Conversation

Aritra8438
Copy link
Member

@Aritra8438 Aritra8438 commented Jul 6, 2023

Fixes #3005

This PR adds Peak Month aggregation function to the Mathesar UI.

Technical details

I have done the following things:

  • Add custom PostgreSQL function for Peak Month aggregation.
  • Add Peak Month to the Mathesar UI.
  • Add tests for the same.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big picture is the same as my previous review. I think the calculations should be less discrete, and open the potential for figuring out the peak day in a year, or peak month, or peak week (Germans would like this).

@rajatvijay rajatvijay added the pr-status: revision A PR awaiting follow-up work from its author after review label Jul 7, 2023
@rajatvijay rajatvijay added this to the GSoC 2023 milestone Jul 7, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front end changes look good.

All my concerns from Peak Day of Week apply here as well though.

@Aritra8438 Aritra8438 changed the base branch from add-peak-dow-aggregation to develop July 13, 2023 16:42
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Thanks for the great comments explaining the functions.

The only change I have to request is to remove the casting of output months to strings. They should either be integers, or 2-digit formatted numeric strings (e.g., '01', '02', '11', '12')

db/sql/3_msar_custom_aggregates.sql Outdated Show resolved Hide resolved
db/sql/3_msar_custom_aggregates.sql Outdated Show resolved Hide resolved
@rajatvijay rajatvijay assigned seancolsen and unassigned Aritra8438 Jul 20, 2023
@rajatvijay rajatvijay added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Jul 20, 2023
@rajatvijay rajatvijay assigned mathemancer and unassigned seancolsen Jul 20, 2023
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good. Thank you!

@mathemancer mathemancer added this pull request to the merge queue Jul 24, 2023
Merged via the queue into develop with commit 1d7469a Jul 24, 2023
18 checks passed
@mathemancer mathemancer deleted the add-peak-month-aggregation branch July 24, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Support for Peak month aggregation function while summarizing columns
4 participants