Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pldebugger to dev db #3126

Merged
merged 1 commit into from Aug 3, 2023
Merged

Add pldebugger to dev db #3126

merged 1 commit into from Aug 3, 2023

Conversation

dmos62
Copy link
Contributor

@dmos62 dmos62 commented Aug 2, 2023

Indirectly part of my work on dynamic defaults.

Adds a debugger to our dev Postgres db. Helps to work with our plpgsql code that @mathemancer has been steadily introducing as part of the removing sqlalchemy project.

My current prefered way to use it is via pgadmin4's debugger. Before using, debugger's extension must be created via CREATE EXTENSION pldbgapi;.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dmos62 dmos62 added affects: dx Related to developer experience work: backend Related to Python, Django, and simple SQL pr-status: review A PR awaiting review labels Aug 2, 2023
@dmos62 dmos62 added this to the v0.1.3 milestone Aug 2, 2023
@dmos62 dmos62 requested a review from mathemancer August 2, 2023 17:05
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems not to break anything

@mathemancer mathemancer added this pull request to the merge queue Aug 3, 2023
Merged via the queue into develop with commit 8c8dc44 Aug 3, 2023
17 checks passed
@mathemancer mathemancer deleted the add-pldebugger-to-dev-db branch August 3, 2023 05:38
@silentninja
Copy link
Contributor

silentninja commented Aug 4, 2023

This PR is causing a regression. The dev-db service fails with the following error even after rebuilding the Docker image

 [1] FATAL:  could not access file "plugin_debugger": No such file or directory

Update: I rebuilt the image and I am not getting that error anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: dx Related to developer experience pr-status: review A PR awaiting review work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants