Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN:NaN error while aggregating duration column #3136

Merged
merged 6 commits into from Aug 15, 2023

Conversation

Aritra8438
Copy link
Member

@Aritra8438 Aritra8438 commented Aug 9, 2023

Fixes #2963

Technical details

This PR:

  • Downcast Interval to string. (which eventually fixes the NaN:NaN part).
  • Adds some tests for the same.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Aritra8438 Aritra8438 self-assigned this Aug 9, 2023
@Aritra8438 Aritra8438 added the pr-status: review A PR awaiting review label Aug 9, 2023
@Aritra8438 Aritra8438 marked this pull request as ready for review August 9, 2023 20:15
@Aritra8438
Copy link
Member Author

Aritra8438 commented Aug 9, 2023

Hi, @mathemancer.
This PR solves the interval error!

On contrary to our guess, it was not a frontend issue (atleast, not wrt currently what we are doing in frontend).

@rajatvijay rajatvijay added this to the Backlog milestone Aug 10, 2023
@rajatvijay rajatvijay assigned mathemancer and unassigned Aritra8438 Aug 10, 2023
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for this!

@mathemancer mathemancer added this pull request to the merge queue Aug 15, 2023
Merged via the queue into develop with commit bb70b08 Aug 15, 2023
21 checks passed
@mathemancer mathemancer deleted the Fix-interval-error branch August 15, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Distinct list results in NaN:NaN when applied on Duration columns.
3 participants