Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read-only css for input #3197

Merged
merged 5 commits into from Oct 5, 2023

Conversation

manthan-jsharma
Copy link
Contributor

Fixes #3192

Technical details

This PR contains the changes where two things are done

  1. addition of read-only class only if readonly prop is passed from parent
  2. making read-only selector to class as read-only class can be used as conditional render

Screenshots

Screenshots of input with read only prop

Screenshot 2023-09-04 at 1 22 05 AM

Screenshots of input inside ul element without read only prop

Screenshot 2023-09-04 at 1 27 21 AM

Screenshots of normal input

Screenshot 2023-09-04 at 1 30 14 AM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@manthan-jsharma
Copy link
Contributor Author

@pavish, could you kindly review this PR? I've thoroughly examined the codebase and found that this is the only instance where 'ul' is wrapped inside a custom input.

@seancolsen
Copy link
Contributor

Note we have two PRs for the same issue: #3197 and #3196. @pavish I'll leave it to you as to how to best handle this.

@rajatvijay rajatvijay added this to the Next release milestone Sep 22, 2023
@seancolsen seancolsen modified the milestones: Next release, v0.1.4 Oct 2, 2023
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manthan-jsharma Thanks for the PR!

The approach you've taken is mostly good, I have a tiny comment: You exports readOnly as a prop, which isn't required since readonly is an html attribute and we would like to use in a similar manner which is already handled by $$restProps.

I've added a small commit 94733c5 which removes this external export.

@pavish pavish added this pull request to the merge queue Oct 5, 2023
Merged via the queue into mathesar-foundation:develop with commit 0d430be Oct 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Visual regression: Custom input elements appear disabled
4 participants