New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check constraints on a table breaking the app #3243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anish9901
changed the title
Handle check constraints on a table breaking the app
Fix check constraints on a table breaking the app
Oct 12, 2023
mathemancer
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; nice work!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 20, 2023
mathemancer
removed this pull request from the merge queue due to the queue being cleared
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3109
Technical details
Previously 'check' and 'exclude' constraints weren't present in the
serializers_mapping
dict which causedto_representation
to return the input instance as it is w/o serializing it which caused the app to break as shown in the issue.Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin