Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check constraints on a table breaking the app #3243

Merged
merged 5 commits into from Oct 27, 2023

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Oct 12, 2023

Fixes #3109

Technical details

Previously 'check' and 'exclude' constraints weren't present in the serializers_mapping dict which caused to_representation to return the input instance as it is w/o serializing it which caused the app to break as shown in the issue.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 changed the title Handle check constraints on a table breaking the app Fix check constraints on a table breaking the app Oct 12, 2023
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Oct 12, 2023
@Anish9901 Anish9901 modified the milestones: v0.1.5, High priority Oct 12, 2023
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; nice work!

@mathemancer mathemancer added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 19, 2023
@Anish9901 Anish9901 added this pull request to the merge queue Oct 19, 2023
@Anish9901 Anish9901 added the work: backend Related to Python, Django, and simple SQL label Oct 19, 2023
@Anish9901 Anish9901 removed this pull request from the merge queue due to a manual request Oct 19, 2023
@Anish9901 Anish9901 removed the work: backend Related to Python, Django, and simple SQL label Oct 19, 2023
@Anish9901 Anish9901 added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 19, 2023
@Anish9901 Anish9901 added this pull request to the merge queue Oct 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 20, 2023
@mathemancer mathemancer added this pull request to the merge queue Oct 23, 2023
@mathemancer mathemancer removed this pull request from the merge queue due to the queue being cleared Oct 23, 2023
@mathemancer mathemancer added this pull request to the merge queue Oct 27, 2023
Merged via the queue into develop with commit c714892 Oct 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Links do not work after adding check constraint to a table
2 participants