Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup DB: detect tables present #131

Closed
1 task done
nphilipp opened this issue Dec 6, 2021 · 0 comments · Fixed by #132
Closed
1 task done

Setup DB: detect tables present #131

nphilipp opened this issue Dec 6, 2021 · 0 comments · Fixed by #132
Assignees
@nphilipp
Labels
bug database concerning database models, migration, …
Projects
Q4/2021 Initiative

Comments

@nphilipp
Copy link
Collaborator

nphilipp commented Dec 6, 2021 •
edited

Story

As a an operator of Duffy,
I want to know if tables are present when trying to install the DB schema,
so that I don't think the schema is compatible with the code if it isn't.

Acceptance Criteria

  • duffy setup-db will warn about tables being present rather than acting as if it did anything when it didn't

Background

MetaData.create_all() will check first if tables are present and then silently do nothing if that's the case.
@nphilipp nphilipp created this issue from a note in Q4/2021 Initiative (To do) Dec 6, 2021
@nphilipp nphilipp moved this from To do to In progress in Q4/2021 Initiative Dec 6, 2021
@nphilipp nphilipp self-assigned this Dec 6, 2021
@nphilipp nphilipp added bug database concerning database models, migration, … labels Dec 6, 2021
nphilipp added a commit to nphilipp/duffy that referenced this issue Dec 6, 2021
@nphilipp
Make setup-db fail if tables are present
4776c17 
Fixes: CentOS#131

Signed-off-by: Nils Philippsen <nils@redhat.com>
@nphilipp nphilipp mentioned this issue Dec 6, 2021
Merged
@nphilipp nphilipp moved this from In progress to In Review in Q4/2021 Initiative Dec 6, 2021
nphilipp added a commit to nphilipp/duffy that referenced this issue Dec 6, 2021
@nphilipp
Make setup-db fail if tables are present
cda789b 
Fixes: CentOS#131

Signed-off-by: Nils Philippsen <nils@redhat.com>
nphilipp added a commit to nphilipp/duffy that referenced this issue Dec 6, 2021
@nphilipp
Make setup-db fail if tables are present
c31b3c2 
Fixes: CentOS#131

Signed-off-by: Nils Philippsen <nils@redhat.com>
Q4/2021 Initiative automation moved this from In Review to Done Dec 7, 2021
gridhead pushed a commit that referenced this issue Dec 7, 2021
@nphilipp @gridhead
Make setup-db fail if tables are present
2bda5b9 
Fixes: #131

Signed-off-by: Nils Philippsen <nils@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphilipp nphilipp

Labels
bug database concerning database models, migration, …
Projects
No open projects
Q4/2021 Initiative
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make setup-db fail if tables are present nphilipp/duffy
1 participant
@nphilipp