fix(responsetemplate/mgr): improve description for `423 Empty API res…

…ponse` [HM-577]
centralnicgroup-opensource · Oct 4, 2019 · 7bbcee9 · 7bbcee9
1 parent 78521d5
commit 7bbcee9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/hexonet/apiconnector/responsetemplate.py b/hexonet/apiconnector/responsetemplate.py
@@ -21,7 +21,7 @@ def __init__(self, response=""):
         #: Holds the response as plain text / string
         self.__raw = response
         if (response is "") or (response is None):
-            self.__raw = "[RESPONSE]\r\nCODE=423\r\nDESCRIPTION=Empty API response\r\nEOF\r\n"
+            self.__raw = "[RESPONSE]\r\nCODE=423\r\nDESCRIPTION=Empty API response. Probably unreachable API end point\r\nEOF\r\n"
 
         # try/except to support old versions of python (python2.5)
         try:

diff --git a/hexonet/apiconnector/responsetemplatemanager.py b/hexonet/apiconnector/responsetemplatemanager.py
@@ -29,7 +29,7 @@ def __new__(self):
         ResponseTemplateManager.__templates = {
             "404": rtm.generateTemplate("421", "Page not found"),
             "500": rtm.generateTemplate("500", "Internal server error"),
-            "empty": rtm.generateTemplate("423", "Empty API response"),
+            "empty": rtm.generateTemplate("423", "Empty API response. Probably unreachable API end point"),
             "error": rtm.generateTemplate("421", "Command failed due to server error. Client should try again"),
             "expired": rtm.generateTemplate("530", "SESSION NOT FOUND"),
             "httperror": rtm.generateTemplate("421", "Command failed due to HTTP communication error"),

diff --git a/tests/test_responsetemplate.py b/tests/test_responsetemplate.py
@@ -5,19 +5,19 @@ def test_responsetemplatemethods():
     # check instance [raw empty string]
     tpl = ResponseTemplate()
     assert tpl.getCode() == 423
-    assert tpl.getDescription() == 'Empty API response'
+    assert tpl.getDescription() == 'Empty API response. Probably unreachable API end point'
 
     # #.getHash
     h = tpl.getHash()
     assert h["CODE"] == '423'
-    assert h["DESCRIPTION"] == 'Empty API response'
+    assert h["DESCRIPTION"] == 'Empty API response. Probably unreachable API end point'
 
     # #.getQueuetime
     # [not in api response]
     assert tpl.getQueuetime() == 0.00
     # [in api response]
     tpl2 = ResponseTemplate(
-        '[RESPONSE]\r\ncode=423\r\ndescription=Empty API response\r\nqueuetime=0\r\nruntime=0.12\r\nEOF\r\n')
+        '[RESPONSE]\r\ncode=423\r\ndescription=Empty API response. Probably unreachable API end point\r\nqueuetime=0\r\nruntime=0.12\r\nEOF\r\n')
     assert tpl2.getQueuetime() == 0.00
 
     # #.getRuntime
@@ -31,5 +31,5 @@ def test_responsetemplatemethods():
     assert tpl.isPending() is False
     # [in api response]
     tpl2 = ResponseTemplate(
-        '[RESPONSE]\r\ncode=423\r\ndescription=Empty API response\r\npending=1\r\nEOF\r\n')
+        '[RESPONSE]\r\ncode=423\r\ndescription=Empty API response. Probably unreachable API end point\r\npending=1\r\nEOF\r\n')
     assert tpl2.isPending() is True