Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol: do not use unlimited history option by default #196

Closed
FZambia opened this issue May 3, 2021 · 1 comment
Closed

Protocol: do not use unlimited history option by default #196

FZambia opened this issue May 3, 2021 · 1 comment
Milestone

Comments

@FZambia
Copy link
Member

FZambia commented May 3, 2021

Currently when clients call channel history they receive all Publications kept in stream. Since we now have a pagination it's likely that streams may be a bigger size than before.

The plan is to make history act with limit == 0 by default. I.e. receive current stream position only (offset + epoch) without publications. While this is a breaking change in a client protocol we can always modify behaviour of history on server side calling node.History inside OnHistory handler.

@FZambia FZambia added this to the v1.0.0 milestone May 9, 2021
@FZambia FZambia modified the milestones: v1.0.0, v0.18.0 Jul 12, 2021
@FZambia
Copy link
Member Author

FZambia commented Aug 23, 2021

Done in 98f6388, will be part of v0.18.0

@FZambia FZambia closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant