Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliable node unsubscribe from PUB/SUB channel #77

Closed
FZambia opened this issue Nov 24, 2019 · 0 comments · Fixed by #83
Closed

Reliable node unsubscribe from PUB/SUB channel #77

FZambia opened this issue Nov 24, 2019 · 0 comments · Fixed by #83

Comments

@FZambia
Copy link
Member

FZambia commented Nov 24, 2019 •
edited

At moment if node unsubscribes from Redis channel (last client leaves channel) and an error happens during unsubscribe request to Redis then subscription to channel can stay alive. This does not affect general behaviour but can lead to stale subscriptions and receiving non-actual messages over PUB/SUB which are then dropped on node level. It would be nice to clean up such subscriptions. One idea is to have a sort of unsubscribe unbounded queue which is consumed by workers to reliably process unsubscriptions.
@FZambia FZambia changed the title Reliable node unsubscribe Reliable node unsubscribe from PUB/SUB channel Nov 24, 2019
@FZambia FZambia mentioned this issue Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dissolve subscriptions over queue with delay centrifugal/centrifuge
1 participant
@FZambia