Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Proxy headers with uppercase letters are no longer passed to the proxy endpoint #572

Closed
hmnhf opened this issue Oct 23, 2022 · 3 comments

Comments

@hmnhf
Copy link

hmnhf commented Oct 23, 2022

Describe the bug. A clear and concise description of what the bug is.

After upgrading to v4.0.2 from v4.0.0, Centrifugo stopped passing the configured proxy headers to the proxy endpoint.
I noticed #558 in v4.0.2 changelogs and changed the configured headers in config.json to have all of their letters lowercased. (E.g. from Foo-Bar-Baz to foo-bar-baz.)

After the change, Centrifugo started passing the proxy headers again. (Double-checked this by reverting and re-applying the config change to make sure the problem is with the uppercase letters.)

Versions

Centrifugo version is 4.0.2
Client library used is centrifuge-go of version v0.9.3
Operating system is macOS

Steps to Reproduce How can the bug be triggered?

  1. Add a connect proxy configuration similar to this:
{
  "connect_proxy_name": "connect"
  "proxies": [
    {
      "name": "connect",
      "endpoint": "https://cent-proxy.example.com/connect",
      "http_headers": ["Foo-Bar-Baz", "Qux-Fred-Thud"]
    }
 }
  1. Send a connect request to the Centrifugo server with Foo-Bar-Baz and Qux-Fred-Thud headers set.

Expected behavior What output or behaviour were you expecting instead?

Centrifugo should pass Foo-Bar-Baz and Qux-Fred-Thud headers to the proxy endpoint, but it doesn't.

@FZambia
Copy link
Member

FZambia commented Oct 23, 2022

@hmnhf hello, thanks for a detailed bug report!

So sorry, this should be fixed with #573 - the issue should only happen if granular_proxy_mode is used.

@FZambia
Copy link
Member

FZambia commented Oct 24, 2022

Fixed in Centrifugo v4.0.3

@FZambia FZambia closed this as completed Oct 24, 2022
@hmnhf
Copy link
Author

hmnhf commented Oct 24, 2022

@FZambia Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants