Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http-client #55

Open
tarjei opened this issue Oct 19, 2022 · 1 comment
Open

Add support for http-client #55

tarjei opened this issue Oct 19, 2022 · 1 comment

Comments

@tarjei
Copy link

tarjei commented Oct 19, 2022

Hi, thanks for this package!

I would be great if you could add support for using psr/http-client instead of hardcoded curl calls for duing the http calls as that would make it a lot easier to write tests of code that depends on this phpcent.

Either that or at least making the request and send methods protected so that it is possible to extend them and provide our own implementation of the http handling.

Regards,
Tarjei

@FZambia
Copy link
Member

FZambia commented Apr 16, 2023

Hello, feel free to open PR which allows extending methods and please provide an example how it's then possible to override those methods for testing. I am personally not using PHP on day to day basis – so prefer someone more experienced to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants