Loans: specify & implement loan's modifications logic.

[lemunozm]

Which part of the code is the issue addressing?

• Feature

Description

The previous reprice method allows the modification of loan attributes instantly without any feedback to the investors. We want these changes to happen after certain time while the investors have feedback to decide if they want to keep their money there.

This forces to the loans pallet to act in the following way in order to modify certain critical loan attributes:

• modify_intent: pallet-loans proposes to modify something, but the modification itself is locked
• The pool unlocks that modification after some time.
• modify: The pallet-loans is able to modify the loan's attributes

Research/based on

• On this sheet
• First design draft in this thread

How will this affect the code base

• Instead of reprice method. This modify allows for protecting investors first, giving clear feedback on what will be changed.

What are forseen obstacles or hurdles to overcome?

• We need first a lock/release mechanism: Implementation of ChangeGuard trait #1207

[mustermeiszer]

Just for reference.

• Requirements for moditifcations: https://docs.google.com/spreadsheets/d/1RJ5RLobAdumXUK7k_ugxy2eDAwI5akvtuqUM2Tyn5ts/edit?pli=1#gid=0
  • orange: high impact changes

[lemunozm]

Done in #1384