Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Substrate ensure_ops methods #1309

Closed
lemunozm opened this issue Apr 10, 2023 · 0 comments · Fixed by #1414
Closed

Use Substrate ensure_ops methods #1309

lemunozm opened this issue Apr 10, 2023 · 0 comments · Fixed by #1414
Labels
D0-ready Pull request can be merged without special precaution and notification. I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing. Q0-trivial An issure which is similar to patching code.

Comments

@lemunozm
Copy link
Contributor

lemunozm commented Apr 10, 2023 •
edited

Description

The Polkadot update 0.9.37 (#1241) already comes with the ensure_ops methods. We should use them instead of our cfg_traits::ops::ensure implementation.

How will this affect the code base

  • Less code to maintain.
@lemunozm lemunozm added Q0-trivial An issure which is similar to patching code. D0-ready Pull request can be merged without special precaution and notification. P2-nice-to-have Issue is worth doing. I11-cleaning No mandatory issue that leave the repo more readable/organized labels Apr 10, 2023
@lemunozm lemunozm mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D0-ready Pull request can be merged without special precaution and notification. I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use substrate ensure_ops implementation centrifuge/centrifuge-chain
1 participant
@lemunozm