Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max ETH gas price to configuration #734

Closed
pstehlik opened this issue Feb 7, 2019 · 2 comments
Closed

Add max ETH gas price to configuration #734

pstehlik opened this issue Feb 7, 2019 · 2 comments
Assignees
@vimukthi-git
Labels
enhancement New feature or request
Milestone
🐟 Amphitrite

Comments

@pstehlik
Copy link
Contributor

pstehlik commented Feb 7, 2019 •
edited

go-centrifuge automatically chooses the gas price for the network it connects to.
We need to have a max value for the gas price to avoid that "all the ETH will be gone" during peak times.
Rather fail a transaction instead of taking all the ETH.
@pstehlik pstehlik added this to the 🌞 Fortuna milestone Feb 7, 2019
@pstehlik pstehlik added bounty-candidate enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 7, 2019
@lucasvo
Copy link
Member

lucasvo commented Feb 8, 2019 •
edited

@pstehlik what about this: https://github.com/ethereum/go-ethereum/wiki/Gas-Price-Oracle ?

Relvant go code: https://github.com/ethereum/go-ethereum/blob/e29c2e43640445e743bb69ab48d6c862d3e964d9/eth/gasprice/gasprice.go

@pstehlik
Copy link
Contributor Author

pstehlik commented Feb 8, 2019

might be also possible.
when grooming this ticket we can decide which way to go and spend a bit more time.

@lucasvo lucasvo modified the milestones: 🌞 Fortuna, 🐟 Amphitrite Mar 27, 2019
@pstehlik pstehlik reopened this Mar 28, 2019
@pstehlik pstehlik changed the title Introduce dynamic gas price Make dynamic gas price handling nicer Mar 28, 2019
@pstehlik pstehlik changed the title Make dynamic gas price handling nicer Add max ETH gas price to configuration Apr 2, 2019
@vimukthi-git vimukthi-git removed bounty-candidate help wanted Extra attention is needed good first issue Good for newcomers labels Apr 2, 2019
@vimukthi-git vimukthi-git self-assigned this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vimukthi-git vimukthi-git

Labels
enhancement New feature or request
Projects
None yet
Milestone
🐟 Amphitrite
Development

No branches or pull requests
3 participants
@lucasvo @pstehlik @vimukthi-git