Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editing floating] api.startEditingCell() does not allow for targeting cells in floating rows #1326

Closed
jkuhs opened this issue Dec 9, 2016 · 4 comments

Comments

@jkuhs
Copy link

jkuhs commented Dec 9, 2016

There doesn't seem to be a way to programmatically start editing a cell in a floating row. I would expect api.startEditingCell() to take a parameter to allow for that.

Maybe add a floating field to StartEditingCellParams and handle it in the same way as for setFocusedCell(rowIndex, colKey, floating)?

Or is there another way?

@ceolter
Copy link
Contributor

ceolter commented Jan 4, 2017

noted. will add this to our list. thanks.

@jkuhs
Copy link
Author

jkuhs commented Jan 11, 2017

A workaround that seems to work for me:
let gridCell = api.getFocusedCell();
(<any>api).rowRenderer.startEditingCell(gridCell, null, null);

@ceolter ceolter changed the title api.startEditingCell() does not allow for targeting cells in floating rows [editing floating] api.startEditingCell() does not allow for targeting cells in floating rows Jan 20, 2017
@hpeikari
Copy link

@jkuhs @ceolter @majoshi1
Looks like there is a bug in ag-grid library.
Take a look at GridApi.prototype.startEditingCell() in file dist/lib/gridApi.js
"floating" is hardcoded to null !!
var gridCellDef = { rowIndex: params.rowIndex, floating: null, column: column };

bug

@makinggoodsoftware
Copy link
Contributor

Hi,

Thank you for raising this issue for us, at this moment we are reviewing how we process Feature Requests/questions that come through from GitHub.

As I am sure you are aware, we offer two products:

ag-Grid - this is entirely free to use in line with our MIT license
ag-Grid Enterprise - our commercial version which funds the development of both versions.

We currently have a very full pipeline of work which can be viewed here: https://www.ag-grid.com/ag-grid-pipeline/

This will be our priority for the coming months and as a result, we don’t have capacity to take feature requests/questions from GitHub, but you might find that yours has already been raised in our pipeline.

We will do a periodic review of GitHub issues for any bugs raised and these can also be tracked on our pipeline page.

Thanks for your understanding.
ag-Grid Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants