Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of configurable fsType in the templates. #1473

Closed
humblec opened this issue Sep 14, 2020 · 1 comment · Fixed by #1771
Closed

make use of configurable fsType in the templates. #1473

humblec opened this issue Sep 14, 2020 · 1 comment · Fixed by #1771
Assignees
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs

Comments

@humblec
Copy link
Collaborator

humblec commented Sep 14, 2020

With latest version (v2.0.1) of external provisioner, its now possible to configure fstype . The fstype on provisioned PVs no longer defaults to "ext4". A defaultFStype arg is added to the provisioner. Admins can also specify this fstype via storage class parameter. If fstype is set in storage class parameter, it will be used. The sidecar arg is only checked if fstype is not set in the SC param

Reference # kubernetes-csi/external-provisioner#400

We could change our deployment template to have this in the examples and can also adjust the sidecar arg accordingly.

@humblec humblec self-assigned this Sep 14, 2020
@Madhu-1 Madhu-1 added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Sep 18, 2020
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Dec 4, 2020

this should be fixed in #1653 reassigning to @agarwal-mudit as he is working on his one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
3 participants