Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MInimum volume size in ceph-csi #214

Closed
Madhu-1 opened this issue Feb 20, 2019 · 15 comments
Closed

MInimum volume size in ceph-csi #214

Madhu-1 opened this issue Feb 20, 2019 · 15 comments

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 20, 2019

What is the minimum volume size supported in ceph-csi for both cephfs and rbd?
I fell an input validation is missing for the same.
@rootfs @gman0 ^^

@gman0
Copy link
Contributor

gman0 commented Feb 20, 2019

For cephfs (configuration docs):

Notes on volume size: when provisioning a new volume, max_bytes quota attribute for this volume will be set to the requested volume size (see Ceph quota documentation). A request for a zero-sized volume means no quota attribute will be set.

smallest quota unit is in bytes.

For RBD, smallest allocation unit seems to be in megabytes http://docs.ceph.com/docs/mimic/rbd/rados-rbd-cmds/#creating-a-block-device-image - even though the RBD plugin passes the size in gigabytes, hmm... @rootfs ?

@lelvisl
Copy link

lelvisl commented Feb 20, 2019

1Gi is minim - #213

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 20, 2019

@lelvisl we need to figure out what is the minimum value for both cephfs and RBD

I think once we address this issue #213 will be fixed

@lelvisl
Copy link

lelvisl commented Feb 20, 2019

ok, really looking forward to the decision.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 27, 2019

@rootfs need your input on this.

@rootfs
Copy link
Member

rootfs commented Feb 27, 2019

let's follow in-tree rbd convention here https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/rbd/rbd_util.go#L584

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 27, 2019

@rootfs what about cephfs? same applies for that one also?

@rootfs
Copy link
Member

rootfs commented Feb 27, 2019

@Madhu-1 good idea

@Madhu-1 Madhu-1 closed this as completed Mar 1, 2019
@Madhu-1 Madhu-1 reopened this Mar 1, 2019
@Madhu-1 Madhu-1 mentioned this issue Mar 1, 2019
@gman0
Copy link
Contributor

gman0 commented Mar 1, 2019

Just a general knowledge question, could you please explain where ceph enforces limit for directory quota to be >1MiB for cephfs? As far as I know, quota is measured in bytes, so it can be as little as 1B no?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Mar 1, 2019

@gman0 if we enforce the rule, we will face this issue in external-provisioner kubernetes-csi/external-provisioner#199

@gman0
Copy link
Contributor

gman0 commented Mar 1, 2019

@Madhu-1 ok but that's an issue with that particular sidecar container. AFAIK neither cephfs nor CSI has such requirement where the quota has to be >1MiB.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Mar 1, 2019

that's an issue with that particular sidecar container. AFAIK neither cephfs nor CSI has such a requirement where the quota has to be >1MiB.

yes, you are right, what could be the minimum volume size we can create in cephfs?

let's follow in-tree rbd convention here https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/rbd/rbd_util.go#L584

@rootfs we cant use this utility function in cephfs as in current code we can create volume of size in bytes (if we want to use the function minimum volume size will be of 1Mib)

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jul 16, 2019

@poornimag can you consider this scenario for cephfs volume create?

@humblec
Copy link
Collaborator

humblec commented Apr 1, 2020

@Madhu-1 iic, we have a roundoff now for both rbd and cephfs volumes whlie provisioning. With that I think this issue can be closed.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Apr 1, 2020

closing this one as we have default for rbd and for cephfs 0 is valid

@Madhu-1 Madhu-1 closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants