ci: automatically add ok-to-test to PRs created by Mergify
#3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added
ci/skip/e2e
mergify
bot
added
component/testing
Mergify does not automatically rebase PRs that are queued for merging (anymore?). Instead, it creates a new draft PR that is expected to get tested by the CI. At the moment someone needs to add the `ok-to-test` label to the PR. This is cumbersome and can cause delays in the merge process. The configuration for Mergify now includes a rule that any PR created by Mergify, will automatically get the `ok-to-test` label. This should make it easier to get PR merged. See-also: ceph#3796 Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic
force-pushed
the
mergify/merge-queue
branch
from
35e522d
to
0aeda6d
Compare
Rakshith-R
reviewed
May 8, 2023
| conditions: | ||
| - base~=^(devel)|(release-.+)$ | ||
| - "check-pending=Queue: Embarked in merge train" | ||
| - author=mergify |
There was a problem hiding this comment.
Suggested change
| - author=mergify | |
| - or: | |
| - author=mergify | |
| - "check-pending=Queue: Embarked in merge train" |
I think we need one of either checks to pass for adding ok-to-test?
The second check is still required for upto date pr with only one pr in queue / the original pr even if mergifyio does speculative checks ?
There was a problem hiding this comment.
The 2nd check would not need to add the ok-to-test label if the PR is up to date. The Queue: Embarked in merge train message only appears when all required CI jobs have passed.
Rakshith-R
approved these changes
May 8, 2023
riya-singhal31
approved these changes
May 8, 2023
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mergify does not automatically rebase PRs that are queued for merging (anymore?). Instead, it creates a new draft PR that is expected to get tested by the CI. At the moment someone needs to add the
ok-to-testlabel to the PR. This is cumbersome and can cause delays in the merge process.The configuration for Mergify now includes a rule that any PR created by Mergify, will automatically get the
ok-to-testlabel. This should make it easier to get PR merged.See-also: #3796
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results